Allow cli users to authorize Staker signed by Withdrawer #23146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, CI failure looks unrelated to this change. I'm seeing it repro on master locally. |
|
CI issue fixed here: #23160 |
CriesofCarrots
force-pushed
the
cli-stake-auth
branch
from
ae41486 to
f6465d2
Compare
mergify bot
pushed a commit
that referenced
this pull request
Feb 16, 2022
(cherry picked from commit 88b66ae)
mergify bot
pushed a commit
that referenced
this pull request
Feb 16, 2022
(cherry picked from commit 88b66ae)
mergify bot
added a commit
that referenced
this pull request
Feb 16, 2022
…3175) (cherry picked from commit 88b66ae) Co-authored-by: Tyera Eulberg <[email protected]>
CriesofCarrots
pushed a commit
that referenced
this pull request
Feb 16, 2022
…3176) (cherry picked from commit 88b66ae) Co-authored-by: Tyera Eulberg <[email protected]>
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Feb 16, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The stake program allows either the current stake or withdraw authority to sign for a change to the stake authority, but solana-cli does not, because it does a strict staker-to-staker comparison in pre-tx checks:
solana/cli/src/stake.rs
Line 1387 in a43d04d
Summary of Changes
Check both withdraw and stake current authorities and ensure one of them matches. If neither does, the error message prints the Staker as the
expectedpubkey